pensz commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r658437027
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
##########
@@ -85,16 +94,6 @@ public CliChangelogResultView(CliClient client,
ResultDescriptor resultDescripto
return Arrays.copyOfRange(resultRow, 1, resultRow.length);
}
- @Override
- protected int computeColumnWidth(int idx) {
Review comment:
To optimize changelog table result view ,I think computeColumnWIdth
with following code will be better.
```
protected int computeColumnWidth(int idx) {
PrintUtils.columnWidthByType(column, ....)
}
```
Another benefit is that constructor of CliResultView is no need to change,
subclass of CliResultView can implement computeColumnWIdth differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
