sv3ndk commented on pull request #16245: URL: https://github.com/apache/flink/pull/16245#issuecomment-868458983
@wuchong , I added the unit test you suggested in `select.q`. After doing so I'm realizing the truncation logic works as expected but might be a bit confusing to end-users: if some value is wider that the configured max width, if its type has variable length (e.g. String) it gets truncated, whereas if it has a fixed length (e.g. Timestamp) the width of the type is used instead. This logic is currently implemented in `PrintUtils.columnWidthsByType`, which I've not updated. Maybe I should update it to make sure the max width is applied to all types? It would impact the SQL client as well as other places of Flink that depend on that class. What's your opinion on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
