wuchong commented on a change in pull request #16245:
URL: https://github.com/apache/flink/pull/16245#discussion_r659116064
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliChangelogResultView.java
##########
@@ -85,16 +94,6 @@ public CliChangelogResultView(CliClient client,
ResultDescriptor resultDescripto
return Arrays.copyOfRange(resultRow, 1, resultRow.length);
}
- @Override
- protected int computeColumnWidth(int idx) {
Review comment:
I second @sv3ndk 's point here. `computeColumnWidth` is not a good
design before, because `tableau` mode doesn't use it. `ResultDescriptor` is a
good place to put the initialized column widths and make all modes to have the
same getting column width logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
