zhuzhurk commented on a change in pull request #16485:
URL: https://github.com/apache/flink/pull/16485#discussion_r669411980
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/PhysicalSlotProviderImplWithSpreadOutStrategyTest.java
##########
@@ -109,8 +109,10 @@ public void testSlotAllocationFulfilledWithNewSlots()
@Test
public void
testIndividualBatchSlotRequestTimeoutCheckIsDisabledOnAllocatingNewSlots()
throws Exception {
- TestingSlotPoolImpl slotPool =
- new
SlotPoolBuilder(physicalSlotProviderResource.getMainThreadExecutor()).build();
+ DeclarativeSlotPoolBridge slotPool =
+ new DeclarativeSlotPoolBridgeBuilder(
+
physicalSlotProviderResource.getMainThreadExecutor())
+ .build();
assertThat(slotPool.isBatchSlotRequestTimeoutCheckEnabled(), is(true));
Review comment:
This is an `org.junit.Assert.assertThat` and can be replaced
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/PhysicalSlotProviderImplWithDefaultSlotSelectionStrategyTest.java
##########
@@ -66,8 +66,10 @@ public void testSlotAllocationFulfilledWithNewSlots()
@Test
public void
testIndividualBatchSlotRequestTimeoutCheckIsDisabledOnAllocatingNewSlots()
throws Exception {
- TestingSlotPoolImpl slotPool =
- new
SlotPoolBuilder(physicalSlotProviderResource.getMainThreadExecutor()).build();
+ DeclarativeSlotPoolBridge slotPool =
+ new DeclarativeSlotPoolBridgeBuilder(
+
physicalSlotProviderResource.getMainThreadExecutor())
+ .build();
assertThat(slotPool.isBatchSlotRequestTimeoutCheckEnabled(), is(true));
Review comment:
This is an `org.junit.Assert.assertThat` and can be replaced
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPoolUtils.java
##########
@@ -55,6 +59,16 @@ private SlotPoolUtils() {
throw new UnsupportedOperationException("Cannot instantiate this
class.");
}
+ public static DeclarativeSlotPoolBridge createDeclarativeSlotPoolBridge() {
+ return new DeclarativeSlotPoolBridge(
Review comment:
Maybe use `DeclarativeSlotPoolBridgeBuilder` to build it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
