tillrohrmann commented on a change in pull request #16485:
URL: https://github.com/apache/flink/pull/16485#discussion_r669446794
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java
##########
@@ -488,6 +488,17 @@ public int getNumPendingRequests() {
return pendingRequests.size();
}
+ @VisibleForTesting
+ void runBatchSlotTimeoutCheck() {
Review comment:
This is a good idea. I'll change it. Moreover, I'll add an
`assertRunningInMainThread` to the `checkBatchSlotTimeout` to document that you
should not call `checkBatchSlotTimeout` outside of the `mainThreadExectuor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
