tillrohrmann commented on a change in pull request #16485:
URL: https://github.com/apache/flink/pull/16485#discussion_r669477094
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/e2e/SchedulerEndToEndBenchmarkBase.java
##########
@@ -74,56 +60,18 @@ public void setup(JobConfiguration jobConfiguration) throws
Exception {
final List<JobVertex> jobVertices =
createDefaultJobVertices(jobConfiguration);
jobGraph = createJobGraph(jobVertices, jobConfiguration);
- physicalSlotProvider =
- createPhysicalSlotProvider(
- jobConfiguration, jobVertices.size(),
mainThreadExecutor);
+ physicalSlotProvider = createPhysicalSlotProvider(mainThreadExecutor);
}
private static PhysicalSlotProvider createPhysicalSlotProvider(
- JobConfiguration jobConfiguration,
- int numberOfJobVertices,
- ComponentMainThreadExecutor mainThreadExecutor)
- throws Exception {
- final int slotPoolSize = jobConfiguration.getParallelism() *
numberOfJobVertices;
+ ComponentMainThreadExecutor mainThreadExecutor) throws Exception {
- final SlotPoolImpl slotPool = new
SlotPoolBuilder(mainThreadExecutor).build();
- final TestingTaskExecutorGateway testingTaskExecutorGateway =
- new
TestingTaskExecutorGatewayBuilder().createTestingTaskExecutorGateway();
- offerSlots(
- slotPool,
- new RpcTaskManagerGateway(testingTaskExecutorGateway,
JobMasterId.generate()),
- slotPoolSize,
- mainThreadExecutor);
+ final SlotPool slotPool = new
DeclarativeSlotPoolBridgeBuilder(mainThreadExecutor).build();
return new PhysicalSlotProviderImpl(
Review comment:
Ok, will do this change. On a side note, I think the test should guard
the assumption that vertices are deployed. With my change I could make it pass
even though I broke the underlying assumptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
