rkhachatryan commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r678121291
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java
##########
@@ -45,8 +47,12 @@
*
* <p>Only a bounded number of checkpoints is kept. When exceeding the
maximum number of
* retained checkpoints, the oldest one will be discarded.
+ *
+ * @return the subsumed oldest completed checkpoint if possible, return
null if no checkpoint
+ * needs to be discarded on subsume.
*/
- void addCheckpoint(
+ @Nullable
+ CompletedCheckpoint addCheckpointAndSubsumeOldestOne(
Review comment:
commented in the original
[thread](https://github.com/apache/flink/pull/16582#discussion_r678121731).
~The new name doesn't seem to reflect what the method actually does.~
~It doesn't necessarily subsume **one** checkpoint (or **any** checkpoints
at all).~
~The correct name would be
`addAndMaybeSubsumeOldestAndReturnTheLatestSubsumedIfAny` - which clearly
indicates to me that the new functionality should be in a separate method.~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
