Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r678144570
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java
##########
@@ -67,6 +75,7 @@ public static void subsume(
}
// Don't break out from the loop to subsume intermediate savepoints
}
+ return lastSubsumedCheckpoint;
Review comment:
Maybe we could record the latest subsumed checkpoint in the store,
however, this might not get the core idea of current
`CompletedCheckpointStore#addCheckpoint`.
You can take a look at `DefaultCompletedCheckpointStore#addCheckpoint`, once
the `checkpointStateHandleStore.addAndLock(path, checkpoint)` failed, it would
trigger the subsume process anymore to ensure strict high-availability. The
timing to subsume checkpoint is very important and just record a subsumed
checkpoint but not known when that one is subsumed would lose information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
