Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r679131871
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointSubsumeHelper.java
##########
@@ -67,6 +75,7 @@ public static void subsume(
}
// Don't break out from the loop to subsume intermediate savepoints
}
+ return lastSubsumedCheckpoint;
Review comment:
Thanks for Roman sharing the implementation of adding another method
`CompletedCheckpointStore#getLatestSubsumedCheckpointID`. However, I still
prefer to leverage previous `CompletedCheckpointStore#addCheckpoint` to know
the last subsumed checkpoint for reasons:
1. In general, we should make the minimal changes to existing interfaces.
2. Previous method of `CompletedCheckpointStore#addCheckpoint` already act
the role to subsume checkpoint/savepoint when adding a new complete checkpoint.
We could achieve our goal If we just returned the subsumed checkpoint in
previous method instead of return nothing.
3. Adding method of `CompletedCheckpointStore#getLatestSubsumedCheckpointID`
would introduce another method and would also make us lost the timing when the
checkpoint is subsumed.
After offline discussion with each other, we think maybe involving more guys
could help this discussion more clear. Could you share some thoughts here?
@StephanEwen @pnowojski
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
