Myasuka commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r680716956
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamOperatorWrapper.java
##########
@@ -100,6 +102,16 @@ public void notifyCheckpointComplete(long checkpointId)
throws Exception {
}
}
+ public void notifyCheckpointSubsumed(long checkpointId) throws Exception {
+ if (!closed) {
+ if (wrapped instanceof AbstractStreamOperator) {
+ ((AbstractStreamOperator<?>)
wrapped).notifyCheckpointSubsumed(checkpointId);
+ } else if (wrapped instanceof AbstractStreamOperatorV2) {
+ ((AbstractStreamOperatorV2<?>)
wrapped).notifyCheckpointSubsumed(checkpointId);
+ }
Review comment:
Adding the method was to just follow operator hierarchy and we could
extend the usage to other componments ont only keyed state backends if
necessary in the future.
If you don't like to add methods in `PublicEvolving` class, I think it's
fine and I could revert to call `getKeyedStateBackend()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
