Airblader commented on a change in pull request #16592:
URL: https://github.com/apache/flink/pull/16592#discussion_r679835626



##########
File path: flink-filesystems/flink-s3-fs-presto/pom.xml
##########
@@ -33,7 +33,7 @@ under the License.
        <packaging>jar</packaging>
 
        <properties>
-               <presto.version>0.187</presto.version>
+               <presto.version>0.257</presto.version>

Review comment:
       We didn't technically test which of the two changes fixed it (since the 
testing roundtrip takes so long), but I suspect it it's the presto-hive fix, 
not the bump to the AWS dependencies. The AWS dependencies were already on a 
version that should work (and by quite a bit), but the difference between the 
two presto-hive versions is that the sts dependency is now also in presto-hive 
when it wasn't before.
   
   s3-fs-hadoop isn't fixed by any of these changes. For Hadoop you need 
special configuration because Hadoop ships its own credentials provider chain 
mechanism.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to