fapaul commented on a change in pull request #16676:
URL: https://github.com/apache/flink/pull/16676#discussion_r681803300
##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -78,6 +78,18 @@ under the License.
<version>${kafka.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka_${scala.binary.version}</artifactId>
+ <version>${kafka.version}</version>
+ <exclusions>
Review comment:
Unfortunately, I can't exclude all transitive dependencies because the
old tests are instantiating a KafkaServer. We can either think of moving the
KafkaSink to a different module or keep it as is until we remove all the old
tests and can properly exclude the transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
