tzulitai edited a comment on pull request #248: URL: https://github.com/apache/flink-statefun/pull/248#issuecomment-894728049
> > * The embedded E2E should have two separate jars as well, likewise to the Java E2E - a driver module, and another module only containing the embedded function. > > Are you saying that we download the driver jar as well as embedded jar both into the docker image for launching the cluster? Yes, but for the embedded case, it might not matter since both modules would be loaded by the same classloader anyways. You can ignore this specific comment for now, I'll need to think about whether or not it makes to do this. > > > * Have a parent `pom.xml` that all downstream multilang smoke E2Es' `pom.xml` can immediately extend from, to lessen the amount of boilerplate needed. > > Is it something like an example module with has conly pom.xml in it? Exactly. It isn't an example module, strictly speaking. It has only a pom.xml, and downstream E2E pom.xml's can use that as the parent POM (think for example, the Spring bootstrap Maven POM). > > > * Add a `README.md` to `statefun-smoke-e2e-driver` that illustrates how a developer can add a new smoke E2E for a new language SDK. > > OK. I can try to do this one. Sure, please go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
