evans-ye commented on a change in pull request #248:
URL: https://github.com/apache/flink-statefun/pull/248#discussion_r685364844
##########
File path:
statefun-e2e-tests/statefun-smoke-e2e-java/src/main/java/org/apache/flink/statefun/e2e/smoke/generated/Command.java
##########
@@ -0,0 +1,5005 @@
+// Generated by the protocol buffer compiler. DO NOT EDIT!
+// source: commands.proto
+
+package org.apache.flink.statefun.e2e.smoke.generated;
Review comment:
I'm not quite get this one.
For driver(previously common), we do not generate messages beforehand.
It was my dirty work which generates messages with shaded protobuf. With
your suggestion to remove TypedValueUtil, those pre-generated messages are gone
in driver.
Or you are saying to remove generated messages in smoke-e2e-java?
##########
File path:
statefun-e2e-tests/statefun-smoke-e2e-java/src/main/java/org/apache/flink/statefun/e2e/smoke/generated/Command.java
##########
@@ -0,0 +1,5005 @@
+// Generated by the protocol buffer compiler. DO NOT EDIT!
+// source: commands.proto
+
+package org.apache.flink.statefun.e2e.smoke.generated;
Review comment:
I'm not quite getting this one.
For driver(previously common), we do not generate messages beforehand.
It was my dirty work which generates messages with shaded protobuf. With
your suggestion to remove TypedValueUtil, those pre-generated messages are gone
in driver.
Or you are saying to remove generated messages in smoke-e2e-java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
