dmvk commented on a change in pull request #16652:
URL: https://github.com/apache/flink/pull/16652#discussion_r686766557
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/EmbeddedCompletedCheckpointStore.java
##########
@@ -35,23 +36,24 @@
private final ArrayDeque<CompletedCheckpoint> checkpoints = new
ArrayDeque<>(2);
- private final Collection<CompletedCheckpoint> suspended = new
ArrayDeque<>(2);
+ private final Collection<CompletedCheckpoint> suspended =
+ Collections.synchronizedList(new ArrayList<>());
Review comment:
This is still needed as we use it later for constructing a new
checkpoint store after failovaer (this simulates persisting these checkpoints
in some kind of remote storage after shutting down store with non-globally
terminal state.
It's also good that we can only recover these checkpoints after shutdown has
been called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
