dmvk commented on a change in pull request #16652:
URL: https://github.com/apache/flink/pull/16652#discussion_r686843756
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java
##########
@@ -2792,24 +2792,23 @@ public void testSharedStateRegistrationOnRestore()
throws Exception {
ExecutionJobVertex jobVertex1 = graph.getJobVertex(jobVertexID1);
- EmbeddedCompletedCheckpointStore store = new
EmbeddedCompletedCheckpointStore(10);
-
+ final EmbeddedCompletedCheckpointStore store = new
EmbeddedCompletedCheckpointStore(10);
final List<SharedStateRegistry> createdSharedStateRegistries = new
ArrayList<>(2);
// set up the coordinator and validate the initial state
- CheckpointCoordinator checkpointCoordinator =
+ final CheckpointCoordinatorBuilder coordinatorBuilder =
Review comment:
I agree with a sentiment of this, but it seems that creating checkpoints
via execution graph is actually the easiest approach.
I did some research and it would be probably possible to create a wrapper
around PendingCheckpoint (which is hard to setup).
I'd rather leave this one as is for now and maybe create a follow-up issue
for refactoring this if you want. This would probably take me another day as it
would require deep diving into internal data structures of checkpoints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
