dmvk commented on a change in pull request #16652:
URL: https://github.com/apache/flink/pull/16652#discussion_r688343874
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherFailoverITCase.java
##########
@@ -68,11 +67,20 @@
@Before
public void setUp() throws Exception {
super.setUp();
- final CompletedCheckpointStore completedCheckpointStore =
- new EmbeddedCompletedCheckpointStore();
haServices.setCheckpointRecoveryFactory(
- PerJobCheckpointRecoveryFactory.useSameServicesForAllJobs(
- completedCheckpointStore, new
StandaloneCheckpointIDCounter()));
+ new
PerJobCheckpointRecoveryFactory<EmbeddedCompletedCheckpointStore>(
+ (maxCheckpoints, previous) -> {
+ if (previous != null) {
+ // First job attempt failed before cleaning up
the checkpoint store.
+ // This means we need to use the actual
checkpoint store state for
+ // recovery (instead of suspended checkpoints
as usual).
Review comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
