fapaul commented on a change in pull request #16769:
URL: https://github.com/apache/flink/pull/16769#discussion_r686791411



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/sink/KafkaWriter.java
##########
@@ -376,6 +378,11 @@ private void 
initMetrics(FlinkKafkaInternalProducer<byte[], byte[]> producer) {
                         others,
                         kafkaSinkContext.getNumberOfParallelInstances())) {
             return log.getTransactionsToAbort();
+        } catch (KafkaException e) {
+            LOG.warn(
+                    "Cannot abort transactions before startup this might leave 
lingering transactions from previous executions.",

Review comment:
       I suggest using something along the lines of `"Cannot abort transactions 
before startup. Lingering transactions may hold new data back from downstream 
consumers. Please abort these transactions manually.",` 
   
   The problem, in general, is not only occurring if the application has no 
access but also if there are not enough brokers configured to have the 
__transaction_state topic replicated to. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to