fapaul commented on a change in pull request #16769:
URL: https://github.com/apache/flink/pull/16769#discussion_r686893516
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSink.java
##########
@@ -323,18 +339,62 @@ public int hashCode() {
valueSerialization,
keyFieldGetters,
valueFieldGetters,
- hasMetadata,
+ hasMetadata(),
metadataPositions,
upsertMode);
return new FlinkKafkaProducer<>(
topic,
kafkaSerializer,
properties,
- sinkSemantic.getSemantic(),
+ getSemantic(deliveryGuarantee),
FlinkKafkaProducer.DEFAULT_KAFKA_PRODUCERS_POOL_SIZE);
}
+ private int[] getMetadataPositions(List<LogicalType> physicalChildren) {
Review comment:
Sounds like a good idea but I would also consider it a follow-up
improvement once we have found a good way to replace the serialization schema
and only have to support one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
