AHeise commented on a change in pull request #16769:
URL: https://github.com/apache/flink/pull/16769#discussion_r686889431
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicSink.java
##########
@@ -172,20 +185,43 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
final SerializationSchema<RowData> valueSerialization =
createSerialization(context, valueEncodingFormat,
valueProjection, null);
- final FlinkKafkaProducer<RowData> kafkaProducer =
- createKafkaProducer(keySerialization, valueSerialization);
-
if (flushMode.isEnabled() && upsertMode) {
BufferedUpsertSinkFunction buffedSinkFunction =
Review comment:
Okay the name is pretty bad. It would be awesome if we can provide the
functionality as part of this PR. You'd need to implement a delegating sink
where the writer is wrapped. We can also create a follow-up ticket for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
