AHeise commented on a change in pull request #16590: URL: https://github.com/apache/flink/pull/16590#discussion_r688022693
########## File path: flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/testutils/KafkaSourceSplitDataWriter.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.kafka.source.testutils; + +import org.apache.flink.connectors.test.common.external.SourceSplitDataWriter; + +import org.apache.kafka.clients.producer.KafkaProducer; +import org.apache.kafka.clients.producer.ProducerRecord; +import org.apache.kafka.common.TopicPartition; + +import java.nio.charset.StandardCharsets; +import java.util.Collection; +import java.util.Properties; + +/** Source split data writer for writing test data into Kafka topic partitions. */ +public class KafkaSourceSplitDataWriter implements SourceSplitDataWriter<String> { Review comment: Hm I see your point and I am a bit torn. On the one hand, I'd argue that partitions is such a wide-spread concept in data storage and probably better known than splits which is just a concept in distributed data ingestion/processing. On the other hand, is this very specific to source developers. So I'm probably fine either way for now. Let's make sure everything is `@Experimental` so that we could change that in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
