AHeise commented on a change in pull request #16590:
URL: https://github.com/apache/flink/pull/16590#discussion_r688026116
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceITCase.java
##########
@@ -26,6 +26,15 @@
import org.apache.flink.configuration.Configuration;
import
org.apache.flink.connector.kafka.source.enumerator.initializer.OffsetsInitializer;
import
org.apache.flink.connector.kafka.source.reader.deserializer.KafkaRecordDeserializationSchema;
+import
org.apache.flink.connector.kafka.source.testutils.KafkaMultipleTopicExternalContext;
Review comment:
I don't quite understand the changes in this file. This looks to me if
you have "only" converted the tests from JUnit4 to JUnit5. If so please move in
some extra commit. I'd also like to see the reason of moving the tests inside a
nested test class. Aren't all tests `KafkaSpecificTests`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
