PatrickRen commented on a change in pull request #16809:
URL: https://github.com/apache/flink/pull/16809#discussion_r689397540
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
##########
@@ -128,7 +132,7 @@
static {
KAFKA_SOURCE_PROPERTIES.setProperty("group.id", "dummy");
KAFKA_SOURCE_PROPERTIES.setProperty("bootstrap.servers", "dummy");
-
KAFKA_SOURCE_PROPERTIES.setProperty("flink.partition-discovery.interval-millis",
"1000");
+ KAFKA_SOURCE_PROPERTIES.setProperty("partition.discovery.interval.ms",
"1000");
Review comment:
I assume the purpose of hard-coding here is that the test will fail if
the option key is changed, which can alert that the option change might break
user's DDL. I prefer to keep it for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
