PatrickRen commented on a change in pull request #16809:
URL: https://github.com/apache/flink/pull/16809#discussion_r689399101
##########
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaDynamicTableFactoryTest.java
##########
@@ -212,17 +211,9 @@ public void testTableSource() {
0);
assertEquals(actualKafkaSource, expectedKafkaSource);
- // Test Kafka consumer
ScanTableSource.ScanRuntimeProvider provider =
actualKafkaSource.getScanRuntimeProvider(ScanRuntimeProviderContext.INSTANCE);
- assertThat(provider, instanceOf(SourceFunctionProvider.class));
- final SourceFunctionProvider sourceFunctionProvider =
(SourceFunctionProvider) provider;
- final SourceFunction<RowData> sourceFunction =
- sourceFunctionProvider.createSourceFunction();
- assertThat(sourceFunction, instanceOf(FlinkKafkaConsumer.class));
-
- // Test commitOnCheckpoints flag should be true when set consumer group
- assertTrue(((FlinkKafkaConsumer<?>)
sourceFunction).getEnableCommitOnCheckpoints());
Review comment:
This feature doesn't exist in the new source (committing on checkpoints
is always enabled in new source). I'll remove the test case since it's
validating nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
