CrynetLogistics opened a new pull request #17244:
URL: https://github.com/apache/flink/pull/17244
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*User stories:*
* As a Sink user, I’d like to configure the batch size for items to send to
the destination at once (e.g. “flush if there are x number of items in the
batch”)
* As a Sink user, I’d like to configure the batching logic so that I can
flush the batch of requests based on time period (e.g. “flush every 2 seconds”)
* As a Sink user I’d like to specify the number of bytes for the batch of
requests to be flushed (e.g. ”submit the batch after the total number of bytes
in it is above 1KB”)
* As a Sink developer, I’d like to use the configuration mechanism provided
to allow Sink users to configure my Sink implementation
*Context:*
The AsyncSinkWriter currently has a static batch size. We’d like to allow
Sink users to specify what batch size they would like to use as they are in a
better place to choose a batching logic/size for their needs. We’d like to also
allow Sink developers to make use of the provided configuration mechanism for
their Sink implementations.
*Scope:*
* Allow Sink developers and users to pass batch size config to the
AsyncSinkWriter
* Add support for time-based flushing (e.g. “flush after x miliseconds”)
using the ProcessingTimeService which is part of the Sink interface
* Add support for byte-based flushing
* Consider the combination of time-based flushing and byte-based flushing,
if there are more bytes than configured in the time-based batch, then the last
few (however many necessary) items should go in the next batch to satisfy the
requirement for the number of bytes.
## Brief change log
- *Added byte based flushing to Async Sink Writer*
- *Added time based flushing to Async Sink Writer*
## Verifying this change
This change added tests and can be verified as follows:
- *Added integration tests for successful/unsuccessful persistence of data
in barebones implementation of the generic sink*
- *Added unit tests for added code*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): yes
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
