CrynetLogistics commented on a change in pull request #17244:
URL: https://github.com/apache/flink/pull/17244#discussion_r707546205
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -95,6 +99,21 @@
*/
private int inFlightRequestsCount;
+ /**
+ * Tracks the cumulative size of all elements in {@code
bufferedRequestEntries} to facilitate
+ * the criterion for flushing after {@code flushOnBufferSizeMB} is reached.
+ */
+ private double bufferedRequestEntriesTotalSizeMB;
Review comment:
Yes I think so. I originally picked MB since I saw the elasticsearch
sink use it. But looking at more sinks, it seems to be a personal choice. Bytes
makes more sense for _us_ here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
