CrynetLogistics commented on a change in pull request #17244:
URL: https://github.com/apache/flink/pull/17244#discussion_r707545026
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -118,12 +137,25 @@
protected abstract void submitRequestEntries(
List<RequestEntryT> requestEntries,
Consumer<Collection<RequestEntryT>> requestResult);
+ /**
+ * This method allows the getting of the size of a {@code RequestEntryT}
in bytes. The size in
+ * this case is measured as the total bytes that is written to the
destination as a result of
+ * persisting this particular {@code RequestEntryT} rather than the
serialized length (which may
+ * be the same).
+ *
+ * @param requestEntry the requestEntry for which we want to know the size
+ * @return the size of the requestEntry, as defined previously
Review comment:
Definitely!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
