CrynetLogistics commented on a change in pull request #17244:
URL: https://github.com/apache/flink/pull/17244#discussion_r707568248
##########
File path:
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java
##########
@@ -199,7 +252,32 @@ private void flush() throws InterruptedException {
*/
private void completeRequest(Collection<RequestEntryT>
failedRequestEntries) {
inFlightRequestsCount--;
- failedRequestEntries.forEach(bufferedRequestEntries::addFirst);
+ failedRequestEntries.forEach(failedEntry ->
addEntryToBuffer(failedEntry, true));
+ }
+
+ private void addEntryToBuffer(RequestEntryT entry, boolean insertAtHead) {
+ if (bufferedRequestEntries.isEmpty() && !existsActiveTimerCallback) {
+ registerCallback();
+ }
+ if (insertAtHead) {
+ bufferedRequestEntries.addFirst(entry);
+ } else {
+ bufferedRequestEntries.add(entry);
+ }
+
+ double requestEntrySizeMB = getSizeInMB(entry);
+
+ if (insertAtHead) {
+ bufferedRequestEntriesSizeMB.addFirst(requestEntrySizeMB);
+ } else {
+ bufferedRequestEntriesSizeMB.add(requestEntrySizeMB);
+ }
+
+ bufferedRequestEntriesTotalSizeMB += requestEntrySizeMB;
+ }
Review comment:
It's a lot neater now with just the 1. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
