[ 
https://issues.apache.org/jira/browse/FLINK-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349825#comment-15349825
 ] 

ASF GitHub Bot commented on FLINK-4118:
---------------------------------------

GitHub user iemejia opened a pull request:

    https://github.com/apache/flink/pull/2164

    [FLINK-4118] The docker-flink image is outdated (1.0.2) and can be slimmed 
down

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iemejia/flink FLINK-4118

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2164.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2164
    
----
commit 15bf574bfec2b12ee50f4a21f1b1a43421f632e2
Author: Ismaël Mejía <[email protected]>
Date:   2016-06-23T16:39:50Z

    [FLINK-4118] Update docker image to 1.0.3 and remove unneeded deps
    
    Some of the changes include:
    
    - Remove unneeded dependencies (nano, wget)
    - Remove apt lists to reduce image size
    - Reduce number of layers on the docker image (best docker practice)
    - Remove useless variables and base the code in generic ones e.g.
    FLINK_HOME
    - Change the default JDK from oracle to openjdk-8-jre-headless, based on
    two reasons:
    
    1. You cannot legally repackage the oracle jdk in docker images
    2. The open-jdk headless is more appropriate for a server image (no GUI 
stuff)
    
    - Return port assignation to the standard FLINK one:
    
    Variable: docker-flink -> flink
    
    taskmanager.rpc.port: 6121 -> 6122
    taskmanager.data.port: 6122 -> 6121
    jobmanager.web.port: 8080 -> 8081

commit 523e8b0ece28537635792cc9514d4e9bbaa2c53c
Author: Ismaël Mejía <[email protected]>
Date:   2016-06-24T14:52:22Z

    [FLINK-4118] Base the image on the official java alpine and remove ssh

----


> The docker-flink image is outdated (1.0.2) and can be slimmed down
> ------------------------------------------------------------------
>
>                 Key: FLINK-4118
>                 URL: https://issues.apache.org/jira/browse/FLINK-4118
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ismaël Mejía
>            Priority: Minor
>
> This issue is to upgrade the docker image and polish some details in it (e.g. 
> it can be slimmed down if we remove some unneeded dependencies, and the code 
> can be polished).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to