[ 
https://issues.apache.org/jira/browse/FLINK-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15356822#comment-15356822
 ] 

ASF GitHub Bot commented on FLINK-4118:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2176#discussion_r69102159
  
    --- Diff: flink-contrib/docker-flink/docker-entrypoint.sh ---
    @@ -16,21 +18,23 @@
     # limitations under the License.
     
################################################################################
     
    -jobmanager.rpc.address: %jobmanager%
    -jobmanager.rpc.port: 6123
    -jobmanager.heap.mb: 128
    -
    -taskmanager.rpc.port: 6121
    -taskmanager.data.port: 6122
    -taskmanager.heap.mb: 256
    -taskmanager.numberOfTaskSlots: %nb_slots%
    -
    -parallelization.degree.default: %parallelism%
    +# general configuration
    +sed -i -e "s/taskmanager.numberOfTaskSlots: 
1/taskmanager.numberOfTaskSlots: `grep -c ^processor /proc/cpuinfo`/g" 
$FLINK_HOME/conf/flink-conf.yaml
    --- End diff --
    
    This should only be executed on the JobManager since it will print 
`taskmanager_1  | sed: can't create temp file 
'/usr/local/flink/conf/flink-conf.yamlXXXXXX': Read-only file system` which 
might worry some users.


> The docker-flink image is outdated (1.0.2) and can be slimmed down
> ------------------------------------------------------------------
>
>                 Key: FLINK-4118
>                 URL: https://issues.apache.org/jira/browse/FLINK-4118
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ismaël Mejía
>            Priority: Minor
>
> This issue is to upgrade the docker image and polish some details in it (e.g. 
> it can be slimmed down if we remove some unneeded dependencies, and the code 
> can be polished).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to