[ 
https://issues.apache.org/jira/browse/FLINK-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15357227#comment-15357227
 ] 

ASF GitHub Bot commented on FLINK-4118:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2176
  
    Re 1. I think this should be fine. There is some dynamic code generation 
but this uses Janino as a library so that shouldn't be a problem.
    
    Re 2. I'm not aware of any but it should be easy to add them if we find any 
in the future.
    
    Re 3. This is not easily possible since the `&` is hardcoded in 
`flink-daemon.sh`:
    ```
    $JAVA_RUN $JVM_ARGS ${FLINK_ENV_JAVA_OPTS} "${log_setting[@]}" -classpath 
"`manglePathList "$FLINK_TM_CLASSPATH:$INTERNAL_HADOOP_CLASSPATHS"`" 
${CLASS_TO_RUN} "${ARGS[@]}" > "$out" 2>&1 < /dev/null &
    ```
    I'd be very happy if you'd like to work on adding a flag or setting to make 
the daemons start non-daemonized. It should not be too hard to add that, IMHO.


> The docker-flink image is outdated (1.0.2) and can be slimmed down
> ------------------------------------------------------------------
>
>                 Key: FLINK-4118
>                 URL: https://issues.apache.org/jira/browse/FLINK-4118
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ismaël Mejía
>            Priority: Minor
>
> This issue is to upgrade the docker image and polish some details in it (e.g. 
> it can be slimmed down if we remove some unneeded dependencies, and the code 
> can be polished).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to