[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350646#comment-15350646
]
ASF GitHub Bot commented on FLINK-3034:
---------------------------------------
Github user subhankarb commented on the issue:
https://github.com/apache/flink/pull/1813
@tzulitai, @mjsax thank you very much for your valuable feedback.
1) `additionalKey` was supposed to one time declaration for `SORTED_SET`
and `HASH`. For `HASH`
it is the value of hash name and `SORTED_SET` it is the name of the set. I
assume it would not change once it declares.
2) `JedisPoolConfig`/ `JedisClusterConfig` were not `Serializable` so i
needed a wrapper class for that. @mjsax there is a story for a source for
Redis, so `RedisSinkConfig` would not be a valid one as the config would be
same for sink and source. Thats why i make the `JedisPoolConfig`/
`JedisClusterConfig` ctor private. So that user forced to use the builder class
to avoid confusion.
3) When i started with this i thought it was obvious that if i use PUBSUB
in sink, i would always use it for publish and if i use this in source i would
always use it for subscribe :) .
4 + 5 ) We can group the command and dataType like.
`public enum RedisCommand {
LPUSH(RedisDataType.LIST),
RPUSH(RedisDataType.LIST);
private RedisDataType redisDataType;
RedisCommand(RedisDataType redisDataType) {
this.redisDataType = redisDataType;
}
public boolean isInRedisDataType(RedisDataType redisDataType) {
return this.redisDataType == redisDataType;
}
}`
And in `RedisDataTypeDescription` we can extract the command . So that in
future we can add new command.
> Redis SInk Connector
> --------------------
>
> Key: FLINK-3034
> URL: https://issues.apache.org/jira/browse/FLINK-3034
> Project: Flink
> Issue Type: New Feature
> Components: Streaming Connectors
> Reporter: Matthias J. Sax
> Assignee: Subhankar Biswas
> Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
