[ 
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351701#comment-15351701
 ] 

ASF GitHub Bot commented on FLINK-3034:
---------------------------------------

Github user mjsax commented on the issue:

    https://github.com/apache/flink/pull/1813
  
    My two cents:
    1) seems to got sorted out (thx @tzulitai for the input!)
    2) I personally do not care too much about the name conflict. Reusing the 
same class for sink and source sounds reasonable. Maybe `FlinkRedisConfig` as 
name?
    3) Agreed. `PUBSUB` as datatpye is fine IMHO (so we can use same type for 
source and sink, which makes it clear if PUB or SUB is used)
    4 + 5 ) Your suggestions sound good to me. Please update PR so we can get 
better lock and feel for it :)
    
    @tzulitai @subhankarb Thanks a lot!


> Redis SInk Connector
> --------------------
>
>                 Key: FLINK-3034
>                 URL: https://issues.apache.org/jira/browse/FLINK-3034
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Subhankar Biswas
>            Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to