JingGe commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r737403581
##########
File path: flink-formats/flink-parquet/pom.xml
##########
@@ -45,6 +45,14 @@ under the License.
<scope>provided</scope>
</dependency>
+ <!-- Flink-avro -->
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro</artifactId>
+ <version>${project.version}</version>
Review comment:
hmmm, should be fine. We had internal discussion about this, and let it
be no optional for now. But, optional should be no doubt an option. @AHeise Do
you have any concern about making it optional?
##########
File path: flink-formats/flink-parquet/pom.xml
##########
@@ -45,6 +45,14 @@ under the License.
<scope>provided</scope>
</dependency>
+ <!-- Flink-avro -->
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro</artifactId>
+ <version>${project.version}</version>
Review comment:
should be fine. We had internal discussion about this, and let it be no
optional for now. But, optional should be no doubt an option. @AHeise Do you
have any concern about making it optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
