JingGe commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r737422936



##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -26,7 +26,7 @@ under the License.
                <groupId>org.apache.flink</groupId>
                <artifactId>flink-formats</artifactId>
                <version>1.15-SNAPSHOT</version>
-               <relativePath>..</relativePath>
+               <relativePath>../pom.xml</relativePath>

Review comment:
       > > Why was this change needed?
   > 
   > since we use the default value of relativePath, the whole line could be 
saved. This change follows the official indication. 
http://maven.apache.org/ref/3.3.9/maven-model/maven.html#class_parent Btw, 
Intellij Idea points out the issue too.
   
   @echauchot for the "relativePath" question, please refer to this answer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to