JingGe commented on a change in pull request #17501:
URL: https://github.com/apache/flink/pull/17501#discussion_r737431535
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -26,7 +26,7 @@ under the License.
<groupId>org.apache.flink</groupId>
<artifactId>flink-formats</artifactId>
<version>1.15-SNAPSHOT</version>
- <relativePath>..</relativePath>
+ <relativePath>../pom.xml</relativePath>
Review comment:
> +1 on what Fabian said. IMHO, I think this avro/parquet format should
implement `BulkFormat` directly cf [this
discussion](https://lists.apache.org/thread.html/re3a5724ba3e68d63cd2b83d9d14c41cdcb7547e7c46c6c5e5b7aeb73%40%3Cdev.flink.apache.org%3E)
we had with Jingsong. Regarding block/rowgroup support with BulkFormat: could
it be done by implementing `BulkFormat.Reader#readBatch `?
I could only find the statement of using BulkFormat in that discussion.
Could you share the reason why should we implement BulkFormat directly? BTW,
there was a similar discussion at #17520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
