fapaul commented on a change in pull request #17696:
URL: https://github.com/apache/flink/pull/17696#discussion_r743698529



##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -111,6 +111,15 @@ under the License.
                        <scope>test</scope>
                </dependency>
 
+               <!-- Required to execute the kafka server for testing. Please 
change the zookeeper version accordingly when changing the Kafka version
+             
https://github.com/apache/kafka/blob/839b886f9b732b151e1faeace7303c80641c08c4/gradle/dependencies.gradle#L122
 -->
+               <dependency>
+                       <groupId>org.apache.zookeeper</groupId>
+                       <artifactId>zookeeper</artifactId>
+                       <version>3.5.9</version>
+                       <scope>test</scope>
+               </dependency>
+

Review comment:
       Honestly, I am not sure whether other versions suffice here. I just know 
that the `kafka-server` no longer has this dependency therefore we have to 
include it. I guess other zookeeper versions will also work but this is the one 
currently included by Kafka therefore I left the link to check the 
corresponding version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to