zentol commented on a change in pull request #17696:
URL: https://github.com/apache/flink/pull/17696#discussion_r743682100
##########
File path: flink-connectors/flink-connector-kafka/pom.xml
##########
@@ -111,6 +111,15 @@ under the License.
<scope>test</scope>
</dependency>
+ <!-- Required to execute the kafka server for testing. Please
change the zookeeper version accordingly when changing the Kafka version
+
https://github.com/apache/kafka/blob/839b886f9b732b151e1faeace7303c80641c08c4/gradle/dependencies.gradle#L122
-->
+ <dependency>
+ <groupId>org.apache.zookeeper</groupId>
+ <artifactId>zookeeper</artifactId>
+ <version>3.5.9</version>
+ <scope>test</scope>
+ </dependency>
+
Review comment:
If Kafka needs a specific Zookeeper version then it is better to specify
that in the pom; otherwise this can easily break if we change the Zookeeper
version.
Whether we drop ZK 3.4 or not is largely independent from this in any case,
because that primarily applies to flink-shaded-zookeeper.
It would actually be interesting to know which modules actually rely on
vanilla zookeeper; maybe the root pom entry isn't that useful anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
