slinkydeveloper commented on a change in pull request #17897:
URL: https://github.com/apache/flink/pull/17897#discussion_r757616747
##########
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/filesystem/FileSystemTableSink.java
##########
@@ -343,7 +343,10 @@ private RowDataPartitionComputer partitionComputer() {
@Override
public DynamicTableSource.DataStructureConverter
createDataStructureConverter(
DataType producedDataType) {
- throw new TableException("Compaction reader not support
DataStructure converter.");
+ // This method cannot be implemented without changing the
+ // DynamicTableSink.DataStructureConverter interface
+ throw new UnsupportedOperationException(
Review comment:
I don't, but the reason for this exception to exist is very clear to me:
it's a problem with the design of `DataStructureConverter` propagation to the
connectors, that doesn't allow the sink to create a converter which provides
the `toInternal` logic. Hence, I think it's better to use
`UnsupportedOperationException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
