slinkydeveloper commented on a change in pull request #17897:
URL: https://github.com/apache/flink/pull/17897#discussion_r758476419
##########
File path: flink-connectors/flink-connector-elasticsearch7/pom.xml
##########
@@ -51,6 +51,12 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review comment:
I initially forgot why I added this, but now I recall :)
The problem is that elasticsearch connector requires flink-connector-base
for `DeliveryGuarantee` class. Before this pr, the connector is depending on
this package transitively through flink-table-api-java-bridge ->
flink-table-api-java -> flink-table-common -> flink-connector-files ->
flink-connector-base. Now that there is no flink-connector-files dep anymore,
this dependency is required to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
