slinkydeveloper commented on a change in pull request #17897:
URL: https://github.com/apache/flink/pull/17897#discussion_r759185002



##########
File path: flink-table/flink-table-uber/pom.xml
##########
@@ -88,6 +88,11 @@ under the License.
                        <artifactId>flink-cep</artifactId>
                        <version>${project.version}</version>
                </dependency>
+               <dependency>
+                       <groupId>org.apache.flink</groupId>

Review comment:
       > I'm also skeptical about this change
   
   But this is no different from master. If you build flink-table-uber in 
master, you'll see that flink-connector-files is inside the resulting jar, 
because this is brough in transitively from flink-table-common. If we want to 
do such change, I suggest we do it in a separate PR with a separate issue as 
it's user facing.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to