Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70303482
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchema.java
---
@@ -37,13 +37,15 @@
*
* @param recordKey the records's key as a byte array (null if no key
has been set for the record)
* @param recordValue the record's value as a byte array
- * @param stream the name of the Kinesis stream that this record was
sent to
+ * @param partitionKey the record's partition key at the time of
writing.
* @param seqNum the sequence number of this record in the Kinesis shard
* @param approxArrivalTimestamp the server-side timestamp of when
Kinesis received and stored the record
+ * @param stream the name of the Kinesis stream that this record was
sent to
+ * @param shardId The identifier of the shard the record was sent to.
--- End diff --
nit: some param descriptions end with period, some don't. I think the
others all don't end with period, let's keep consistent with that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
