Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70304158
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchemaWrapper.java
---
@@ -37,15 +37,15 @@ public
KinesisDeserializationSchemaWrapper(DeserializationSchema<T> deserializat
}
@Override
- public T deserialize(byte[] recordKey, byte[] recordValue, String
stream, String seqNum, long approxArrivalTimestamp)
+ public T deserialize(byte[] recordKey, byte[] recordValue, String
partitionKey, String seqNum, long approxArrivalTimestamp, String stream, String
shardId)
throws IOException {
return deserializationSchema.deserialize(recordValue);
}
- @Override
+ /*@Override
public boolean isEndOfStream(T nextElement) {
return deserializationSchema.isEndOfStream(nextElement);
- }
+ } */
--- End diff --
Not sure if we should have commented out code. Open up a JIRA for this
instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
