Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2225#discussion_r70305142
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/serialization/KinesisDeserializationSchema.java
---
@@ -52,5 +54,5 @@
* @param nextElement the element to test for the end-of-stream signal
* @return true if the element signals end of stream, false otherwise
*/
- boolean isEndOfStream(T nextElement);
+ // TODO ADD SUPPORT FOR boolean isEndOfStream(T nextElement);
--- End diff --
Not sure if we should have commented out code. Open up a JIRA for this
instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
