[ 
https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374673#comment-15374673
 ] 

ASF GitHub Bot commented on FLINK-4186:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2236#discussion_r70590934
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
 ---
    @@ -78,7 +79,10 @@
        private final long invalidOffsetBehavior;
     
        /** The interval in which to automatically commit (-1 if deactivated) */
    -   private final long autoCommitInterval; 
    +   private final long autoCommitInterval;
    +
    +   /** The metric group of this operator */
    +   private final MetricGroup metricGroup;
    --- End diff --
    
    the 0.8 Fetcher has a `MetricGroup` field, while the 0.9 Fetcher only 
creates a local variable inside run.  Let's make this more consistent.


> Expose Kafka metrics through Flink metrics
> ------------------------------------------
>
>                 Key: FLINK-4186
>                 URL: https://issues.apache.org/jira/browse/FLINK-4186
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>    Affects Versions: 1.1.0
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> Currently, we expose the Kafka metrics through Flink's accumulators.
> We can now use the metrics system in Flink to report Kafka metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to