[ 
https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374677#comment-15374677
 ] 

ASF GitHub Bot commented on FLINK-4186:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2236#discussion_r70591165
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/Kafka08Fetcher.java
 ---
    @@ -161,6 +167,12 @@ public void runFetchLoop() throws Exception {
                                periodicCommitter.start();
                        }
     
    +                   // register offset metrics
    +                   if(useMetrics) {
    +                           final MetricGroup kafkaMetricGroup = 
metricGroup.addGroup("Kafka08Consumer");
    --- End diff --
    
    i don't think it is necessary to include the version in the group name.


> Expose Kafka metrics through Flink metrics
> ------------------------------------------
>
>                 Key: FLINK-4186
>                 URL: https://issues.apache.org/jira/browse/FLINK-4186
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>    Affects Versions: 1.1.0
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> Currently, we expose the Kafka metrics through Flink's accumulators.
> We can now use the metrics system in Flink to report Kafka metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to