[ 
https://issues.apache.org/jira/browse/FLINK-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374684#comment-15374684
 ] 

ASF GitHub Bot commented on FLINK-4186:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2236#discussion_r70591835
  
    --- Diff: 
flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaConsumerTestBase.java
 ---
    @@ -1235,15 +1235,104 @@ public void flatMap(Tuple2<Integer, Integer> 
value, Collector<Void> out) throws
     
                JobExecutionResult result = tryExecute(env1, "Consume " + 
ELEMENT_COUNT + " elements from Kafka");
     
    -           Map<String, Object> accuResults = 
result.getAllAccumulatorResults();
    -           // kafka 0.9 consumer: 39 results
    -           if (kafkaServer.getVersion().equals("0.9")) {
    -                   assertTrue("Not enough accumulators from Kafka 
Consumer: " + accuResults.size(), accuResults.size() > 38);
    +           deleteTestTopic(topic);
    +   }
    +
    +   /**
    +    * Test metrics reporting for consumer
    --- End diff --
    
    Can we have a test for the producer as well?


> Expose Kafka metrics through Flink metrics
> ------------------------------------------
>
>                 Key: FLINK-4186
>                 URL: https://issues.apache.org/jira/browse/FLINK-4186
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>    Affects Versions: 1.1.0
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> Currently, we expose the Kafka metrics through Flink's accumulators.
> We can now use the metrics system in Flink to report Kafka metrics.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to