XComp commented on a change in pull request #94:
URL: https://github.com/apache/flink-docker/pull/94#discussion_r767741291



##########
File path: add-custom.sh
##########
@@ -12,7 +12,7 @@ function usage() {
 
 binary_download_url=
 name=custom
-java_version=8
+java_version=11

Review comment:
       Still, I would have preferred to rely on the `DEFAULT_JAVA` environment 
variable which is exported in `generator.sh` to have only one location that 
defines the default Java version.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to