XComp commented on a change in pull request #94:
URL: https://github.com/apache/flink-docker/pull/94#discussion_r767873983
##########
File path: add-custom.sh
##########
@@ -12,7 +12,7 @@ function usage() {
binary_download_url=
name=custom
-java_version=8
+java_version=${DEFAULT_JAVA}
Review comment:
Moving this initialization below the while loop using the following code
would make the script more robust:
```
if [ -z "${java_version}" ]; then
[ -z "${DEFAULT_JAVA}" ] && echo "Neither -j nor DEFAULT_JAVA are
specified." && exit 1
java_version="${DEFAULT_JAVA}"
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
