[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392018#comment-15392018
]
ASF GitHub Bot commented on FLINK-4192:
---------------------------------------
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2226
I found out why the `testJobManagerMetricAccess` fails: Since we moved the
JMXReporter to flink-runtime the package declaration changed (it now includes
"runtime"). The class name was hard-coded in that test leading to a
ClassNotFoundException.
I think the JMXReporter should be _somewhere_ else; i dislike that this one
reporter has a different package declaration than other reporters that Flink
offers. I'm thinking of having it in a separate `flink-metrics-jmx` module
under `flink-metrics` that is included in dist.
> Move Metrics API to separate module
> -----------------------------------
>
> Key: FLINK-4192
> URL: https://issues.apache.org/jira/browse/FLINK-4192
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a
> reporter and wants a fat jar it will now have to include the entire
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a
> replacement for the Configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
